[
https://issues.apache.org/jira/browse/PHOENIX-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498278#comment-15498278
]
James Taylor edited comment on PHOENIX-3291 at 9/17/16 5:59 AM:
----------------------------------------------------------------
[~samarthjain] - simple patch - would you mind reviewing? This was driving me
crazy as I was getting a NPE test failure with no stack trace. This change
fixes that.
was (Author: jamestaylor):
[~samarthjain] - simple patch - would you mind reviewing? This was driving me
crazy as I was getting a NPE test failure with no stack trace. This changed
fixes that.
> Do not throw return value of Throwables#propagate call
> ------------------------------------------------------
>
> Key: PHOENIX-3291
> URL: https://issues.apache.org/jira/browse/PHOENIX-3291
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3291.patch
>
>
> Several places in the code are doing the following which is wrong:
> {code}
> throw Throwables.propagate(e);
> {code}
> This seems to get rid of any stack trace. Instead, it should be:
> {code}
> Throwables.propagate(e);
> throw new IllegalStateException(); // won't happen as above call throws
> {code}
> This preserves the stack trace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
