[ 
https://issues.apache.org/jira/browse/PHOENIX-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498582#comment-15498582
 ] 

Hudson commented on PHOENIX-3291:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-master #1405 (See 
[https://builds.apache.org/job/Phoenix-master/1405/])
PHOENIX-3291 Do not throw return value of Throwables#propagate call 
(jamestaylor: rev 553a5871e3c8e2277cebd9f2561b1f2899d1e6d5)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/util/CSVCommonsLoader.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/FormatToBytesWritableMapper.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixContextExecutor.java


> Do not throw return value of Throwables#propagate call
> ------------------------------------------------------
>
>                 Key: PHOENIX-3291
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3291
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: PHOENIX-3291.patch
>
>
> Several places in the code are doing the following which is wrong:
> {code}
> throw Throwables.propagate(e);
> {code}
> This seems to get rid of any stack trace.  Instead, it should be:
> {code}
> Throwables.propagate(e);
> throw new IllegalStateException(); // won't happen as above call throws
> {code}
> This preserves the stack trace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to