[
https://issues.apache.org/jira/browse/PHOENIX-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maryann Xue updated PHOENIX-3242:
---------------------------------
Attachment: PHOENIX-3242-WIP-2.patch
[~rajeshbabu], this is the new patch. The UDF works now. But there seems to be
an issue with UPSERT so I had to tweak the test case a little bit by using the
new calcite-phoenix connection for function creation and UDF queries and using
old Phoenix connection for UPSERT only. It can now pass the UDF queries but
fails at the point of checking function DROP, which is another issue in schema
object caching, I'll open a different JIRA for this.
Yet I didn't get to review your entire patch yet. But I found at least one
issue while I was trying to work out the test case. During function creation,
the single quotes surrounding the class name and the jar path should be trimmed
when you create the function node, otherwise you'd run into trouble at a later
stage. And I believe that's why you were trying to do a fix in PhoenixSchema. I
moved this trimming logic into CREATE_FUNCTION but I'm not sure if there are
better ways to do this with Calcite facilities. And I guess there might be some
other checks in CREATE_FUNCTION that need to be done. So could you please go
through this new patch again and see if there's anything that needs to be
refined?
> Support CREATE OR REPLACE FUNCTION in Phoenix-Calcite Integration
> -----------------------------------------------------------------
>
> Key: PHOENIX-3242
> URL: https://issues.apache.org/jira/browse/PHOENIX-3242
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Attachments: PHOENIX-3242-WIP-2.patch, PHOENIX-3242-wip.patch,
> PHOENIX-3242_select-wip.patch, PHOENIX-3242_v1.patch, PHOENIX-3242_v2.patch,
> PHOENIX-3242_v3.patch, PHOENIX-3242_v4.patch, PHOENIX-3242_v5.patch,
> PHOENIX-3242_v6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
