[ 
https://issues.apache.org/jira/browse/PHOENIX-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543427#comment-15543427
 ] 

ASF GitHub Bot commented on PHOENIX-3298:
-----------------------------------------

GitHub user lomoree opened a pull request:

    https://github.com/apache/phoenix/pull/214

    PHOENIX-3298 Single column primary key may not be null

    Note: This patch will not immediately resolve the 
testInvalidPrimaryKeyDecl() test case due to another issue, PHOENIX-3345. 
However, they are independent issues so there's no reason to wait on this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/phoenix nullcolumns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #214
    
----
commit 669c000c8bea3230f2e895cefebbd00cf6f7d7c6
Author: ERIC LOMORE <elom...@bloomberg.net>
Date:   2016-09-30T06:19:18Z

    PHOENIX-3298 Single column primary key may not be null

----


> Create Table: Single column primary key may not be null
> -------------------------------------------------------
>
>                 Key: PHOENIX-3298
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3298
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Eric Lomore
>            Assignee: Eric Lomore
>         Attachments: PHOENIX-3298-WIP
>
>
> Create table statements with a single column currently must have "NOT NULL" 
> identifier to pass tests.
> Running this code results in failure
> {code}CREATE TABLE t (k VARCHAR PRIMARY KEY DESC){code}
> While this allows tests to pass
> {code}CREATE TABLE t (k VARCHAR NOT NULL PRIMARY KEY DESC){code}
> Must either enforce the not null condition and update test cases, or apply a 
> fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to