[ 
https://issues.apache.org/jira/browse/PHOENIX-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552371#comment-15552371
 ] 

James Taylor commented on PHOENIX-3296:
---------------------------------------

Instead of the new LiteralExpression constructor, can you use 
LiteralExpression.getTypedNullLiteralExpression(PDataType type, Determinism 
determinism)?

In addition to your change for {{nNulls}}, I think there's another existing 
bug. During partial evaluation (i.e. when this.position is set), it's possible 
that we'd reset nNulls back to zero. To prevent this, I think we need to make 
nNulls a member variable and initialize it to 0 in the reset method.

> ArrayConstructor expression does not serialize arrays with leading nulls 
> correctly.
> -----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3296
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3296
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3296.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to