[ 
https://issues.apache.org/jira/browse/PHOENIX-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562823#comment-15562823
 ] 

Maryann Xue commented on PHOENIX-3355:
--------------------------------------

First of all, I don't think we need two sets of classes for these Phoenix 
built-in functions if we just register them as Calcite UDFs. So we need to wait 
for [~rajeshbabu]'s check-in on PHOENIX-3242. And [~rajeshbabu], I have 
approved your patch for UDF part. What you have right now is good enough to get 
[~lomoree] started on this issue. Would you mind checking in ASAP? You can 
continue to work on the default parameter support and other issues related to 
UserDefinedFunctionIT.
And [~lomoree], once the UDF support is in, all we need for this issue is to 
add our built-in functions in implementation of 
PhoenixSchema.getFunctions(String name).
Also, can you give an example of DDL statement you talked about, [~lomoree]?

> Register Phoenix built-in functions as Calcite functions
> --------------------------------------------------------
>
>                 Key: PHOENIX-3355
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3355
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Eric Lomore
>              Labels: calcite
>
> We should register all Phoenix built-in functions that don't exist in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to