Hadoop QA commented on PHOENIX-3349:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against master branch at commit 3e4aec1bc440ad503d5058237e3b508392df9266.
  ATTACHMENT ID: 12833702

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
43 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        ddl = "create SEQUENCE "+schema + "." + sequenceName + " START 
+            tableName = 
+        String schemaName = connection.getSchema() != null && 
statement.getSequenceName().getSchemaName() == null
+        String schemaName = connection.getSchema() != null && 
statement.getTableName().getSchemaName() == null

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
Release audit warnings: 
Javadoc warnings: 
Console output: 

This message is automatically generated.

> DROP TABLE and DROP SEQUENCE not working with schemas
> -----------------------------------------------------
>                 Key: PHOENIX-3349
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3349
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.1
>            Reporter: Francis Chuang
>            Assignee: Ankit Singhal
>              Labels: schema
>             Fix For: 4.9.0, 4.8.2
>         Attachments: PHOENIX-3349.patch
> I am using 4.8.1 with HBase 1.2.3. I am talking to Phoenix using the Phoenix 
> Query Server (Avatica) 
> phoenix.schema.isNamespaceMappingEnabled is set to true in my configuration.
> To reproduce the problem:
> 1. Execute CREATE SCHEMA IF NOT EXISTS myschema
> 2. Open a connection to the query server and set the schema to myschema by 
> setting the info map to {"schema": "myschema"} in the OpenConnectionRequest: 
> https://calcite.apache.org/docs/avatica_protobuf_reference.html#openconnectionrequest
> 2. Execute CREATE TABLE test_table1 (id integer not null primary key)
> 3. ExecuteUPSERT INTO test_table1 (id) VALUES(1)
> Until this point, the schema and table were all created correctly. Upserting 
> also works. If we check system.catalog, we can confirm that the table was 
> created as myschema.test_table1.
> 4. If we attempt to drop the table using the same connection, it neglects to 
> include the schema, so it fails: DROP TABLE test_table1
> {code}
>  RuntimeException: org.apache.phoenix.schema.TableNotFoundException: ERROR 
> 1012 (42M03): Table undefined. tableName=TEST_TABLE1 -> 
> TableNotFoundException: ERROR 1012 (42M03): Table undefined. 
> tableName=TEST_TABLE1
> {code}
> The same problem can be reproduced with DROP SEQUENCE.

This message was sent by Atlassian JIRA

Reply via email to