[ 
https://issues.apache.org/jira/browse/PHOENIX-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585181#comment-15585181
 ] 

Hadoop QA commented on PHOENIX-3161:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12833919/PHOENIX-3161_v1.patch
  against master branch at commit 1e78d3b368b7aa8397224074f691ea2fed340e34.
  ATTACHMENT ID: 12833919

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
43 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                    + 
SchemaUtil.getPhysicalTableName(fullTableName.getBytes(), 
isNamespaceMapped)+"\nCLIENT MERGE SORT";
+                        + 
SchemaUtil.getPhysicalTableName(fullTableName.getBytes(), 
isNamespaceMapped)+"\nCLIENT MERGE SORT";
+                            TableRef tableRef = new TableRef(null, dataPTable, 
HConstants.LATEST_TIMESTAMP, false);
+                            MutationPlan plan = 
compiler.compile(Collections.singletonList(tableRef), null, null, null,
+                            Scan dataTableScan = 
IndexManagementUtil.newLocalStateScan(plan.getContext().getScan(),
+                            
dataTableScan.setAttribute(BaseScannerRegionObserver.REBUILD_INDEXES, 
TRUE_BYTES);
+                            IndexMaintainer.serializeAdditional(dataPTable, 
indexMetaDataPtr, indexesToPartiallyRebuild,
+        } else if (ScanUtil.isIndexRebuild(scan)) { return rebuildIndices(s, 
region, scan, env.getConfiguration()); }
+    private RegionScanner rebuildIndices(final RegionScanner innerScanner, 
final Region region, final Scan scan,
+            int batchSize = config.getInt(MUTATE_BATCH_SIZE_ATTRIB, 
QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/625//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/625//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/625//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/625//console

This message is automatically generated.

> Check possibility of moving rebuilding code to coprocessor of data table.
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-3161
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3161
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3161.patch, PHOENIX-3161_v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to