Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/210#discussion_r83832270
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -305,16 +305,27 @@
TENANT_ID + "," +
TABLE_SCHEM + "," +
TABLE_NAME + "," +
- INDEX_STATE +
+ INDEX_STATE + "," +
+ ASYNC_REBUILD_TIMESTAMP + " " +
PLong.INSTANCE.getSqlTypeName() +
+ ") VALUES (?, ?, ?, ?, ?)";
+
+ private static final String UPDATE_INDEX_REBUILD_ASYNC_STATE =
+ "UPSERT INTO " + SYSTEM_CATALOG_SCHEMA + ".\"" +
SYSTEM_CATALOG_TABLE + "\"( " +
+ TENANT_ID + "," +
+ TABLE_SCHEM + "," +
+ TABLE_NAME + "," +
+ ASYNC_REBUILD_TIMESTAMP + " " +
PLong.INSTANCE.getSqlTypeName() +
") VALUES (?, ?, ?, ?)";
+
private static final String UPDATE_INDEX_STATE_TO_ACTIVE =
"UPSERT INTO " + SYSTEM_CATALOG_SCHEMA + ".\"" +
SYSTEM_CATALOG_TABLE + "\"( " +
TENANT_ID + "," +
TABLE_SCHEM + "," +
TABLE_NAME + "," +
INDEX_STATE + "," +
- INDEX_DISABLE_TIMESTAMP +
- ") VALUES (?, ?, ?, ?, ?)";
+ INDEX_DISABLE_TIMESTAMP +","+
+ ASYNC_REBUILD_TIMESTAMP + " " +
PLong.INSTANCE.getSqlTypeName() +
--- End diff --
Here ASYNC_REBUILD_TIMESTAMP is dynamic column. Are there any problems if
we use dynamic columns for system tables? why can't you make normal column?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
