[
https://issues.apache.org/jira/browse/PHOENIX-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603153#comment-15603153
]
Hadoop QA commented on PHOENIX-2996:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12835000/2996.v1.patch
against master branch at commit 8f5c8cfbd1c1f7894e4cc88e2257d245d1d8c3bf.
ATTACHMENT ID: 12835000
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Set<String> skipWords = new
HashSet<String>(QueryServicesOptions.DEFAULT_QUERY_SERVER_SKIP_WORDS);
+ String[] confSkipWords =
conf.getStrings(QueryServices.QUERY_SERVER_ENV_LOGGING_SKIPWORDS_ATTRIB);
+ final boolean isKerberos =
"kerberos".equalsIgnoreCase(getConf().get(QueryServices.QUERY_SERVER_HBASE_SECURITY_CONF_ATTRIB));
+ LOG.debug("Login to " + hostname + " using " +
getConf().get(QueryServices.QUERY_SERVER_KEYTAB_FILENAME_ATTRIB)
+ + " and principal " +
getConf().get(QueryServices.QUERY_SERVER_KERBEROS_PRINCIPAL_ATTRIB) + ".");
+ QueryServices.QUERY_SERVER_META_FACTORY_ATTRIB,
PhoenixMetaFactoryImpl.class, PhoenixMetaFactory.class);
+ public <T> T doAsRemoteUser(String remoteUserName, String remoteAddress,
final Callable<T> action) throws Exception {
+ assertEquals("query server didn't exit cleanly", 0,
AVATICA_SERVER.getQueryServer().getRetCode());
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/637//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/637//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/637//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/637//console
This message is automatically generated.
> Process name of PQS should indicate its role
> --------------------------------------------
>
> Key: PHOENIX-2996
> URL: https://issues.apache.org/jira/browse/PHOENIX-2996
> Project: Phoenix
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: 2996.v1.patch
>
>
> Currently we have:
> {code}
> * A query server for Phoenix over Calcite's Avatica.
> */
> public final class Main extends Configured implements Tool, Runnable {
> {code}
> Main would show up in the output of jps.
> The class name should be QueryServer or something similar so that user can
> tell its role from the output of jps
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
