[
https://issues.apache.org/jira/browse/PHOENIX-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613680#comment-15613680
]
Hadoop QA commented on PHOENIX-3417:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12835634/PHOENIX-3417.patch
against master branch at commit 927c61205c818fcfd3c743bcb8ddea47a8b04f7f.
ATTACHMENT ID: 12835634
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (minValue != null &&
minValue.getDataType().compareTo(minValue.getValue(), valueExp.getValue(),
valueExp.getDataType()) > 0) {
+ throw new ValueRangeExcpetion(minValue, maxValue == null ?
"" : maxValue, valueExp.getValue(), info.getName() + " argument " + (childIndex
+ 1));
+ if (maxValue != null &&
maxValue.getDataType().compareTo(maxValue.getValue(), valueExp.getValue(),
valueExp.getDataType()) < 0) {
+ throw new ValueRangeExcpetion(minValue == null ? "" :
minValue, maxValue, valueExp.getValue(), info.getName() + " argument " +
(childIndex + 1));
+ throw new ArgumentTypeMismatchException("constant",
child.toString(), info.getName() + " argument " + (childIndex + 1));
+ throw new
ArgumentTypeMismatchException(Arrays.toString(arg.getAllowedValues().toArray(new
String[0])),
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/650//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/650//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/650//console
This message is automatically generated.
> Refactor function argument validation with function argument info to separate
> method
> ------------------------------------------------------------------------------------
>
> Key: PHOENIX-3417
> URL: https://issues.apache.org/jira/browse/PHOENIX-3417
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Minor
> Attachments: PHOENIX-3417.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
