[
https://issues.apache.org/jira/browse/PHOENIX-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614795#comment-15614795
]
Hadoop QA commented on PHOENIX-3422:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12835765/PHOENIX-3422.patch
against master branch at commit 44c5a032818bac2809ef664321542ec77f5df1f9.
ATTACHMENT ID: 12835765
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Object[] typedValues =
PhoenixStorageHandlerUtil.toTypedValues(jobConf, typeName, conditionValues);
+ final String expectedQueryPrefix = "select /*+ NO_CACHE */ " +
COLUMN_CHAR + "," + COLUMN_VARCHAR +
+ mockedIndexSearchCondition("GenericUDFOPEqual", "CHAR_VALUE",
null, COLUMN_CHAR, "char(10)", false),
+ mockedIndexSearchCondition("GenericUDFOPEqual", "CHAR_VALUE2",
null, COLUMN_VARCHAR, "varchar(10)", false)
+ assertEquals(expectedQueryPrefix + "Column_Char = 'CHAR_VALUE' and
Column_VChar = 'CHAR_VALUE2'",
+ PhoenixQueryBuilder.getInstance().buildQuery(jobConf,
tableName, readColumnList, searchConditions));
+ PhoenixQueryBuilder.getInstance().buildQuery(jobConf,
tableName, readColumnList, searchConditions));
+ PhoenixQueryBuilder.getInstance().buildQuery(jobConf,
tableName, readColumnList, searchConditions));
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.schema.MutationTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/653//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/653//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/653//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/653//console
This message is automatically generated.
> PhoenixQueryBuilder doesn't make value string correctly for char(/varchar)
> column type.
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-3422
> URL: https://issues.apache.org/jira/browse/PHOENIX-3422
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Jeongdae Kim
> Labels: HivePhoenix
> Attachments: PHOENIX-3422.patch
>
>
> with a query that includes (v)char column type expression in where clause , a
> query builder can't make a value string that is wrapped with single quote
> character.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
