[
https://issues.apache.org/jira/browse/PHOENIX-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652644#comment-15652644
]
Maryann Xue commented on PHOENIX-3409:
--------------------------------------
Thank you very much for the patch, [~rajeshbabu]! Three things:
1. Could you please correct indentation in "parserImpls.ftl"? There are a lot
of <tab> in your patch.
2. I think {{else if( alterTable.columnNames != null) \{}} should better be
{{else \{ //alterTable.columnNames != null}}.
3. Could you please open another JIRA for double-quoting SYSTEM_CATALOG_SCHEMA
in all queries?
> Support ALTER TABLE in Phoenix-Calcite Integration
> --------------------------------------------------
>
> Key: PHOENIX-3409
> URL: https://issues.apache.org/jira/browse/PHOENIX-3409
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Attachments: PHOENIX-3409.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
