Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/221#discussion_r87436716
  
    --- Diff: 
phoenix-spark/src/main/scala/org/apache/phoenix/spark/ProductRDDFunctions.scala 
---
    @@ -16,19 +16,20 @@ package org.apache.phoenix.spark
     import org.apache.hadoop.conf.Configuration
     import org.apache.hadoop.io.NullWritable
     import org.apache.phoenix.mapreduce.PhoenixOutputFormat
    -import 
org.apache.phoenix.mapreduce.util.{ColumnInfoToStringEncoderDecoder, 
PhoenixConfigurationUtil}
    +import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil
     import org.apache.spark.Logging
     import org.apache.spark.rdd.RDD
    +
     import scala.collection.JavaConversions._
     
     class ProductRDDFunctions[A <: Product](data: RDD[A]) extends Logging with 
Serializable {
     
       def saveToPhoenix(tableName: String, cols: Seq[String],
    -                    conf: Configuration = new Configuration, zkUrl: 
Option[String] = None)
    +                    conf: Configuration = new Configuration, zkUrl: 
Option[String] = None, tenantId: Option[String] = None)
    --- End diff --
    
    Thanks, @jmahonin. If we have to use Configuration object it's ok as long 
as it's not shared between other users (which might have a different TenantId 
or no TenantId). So if you can let us know that there's no sharing going on, 
that's fine too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to