[
https://issues.apache.org/jira/browse/PHOENIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated PHOENIX-3351:
---------------------------------------------
Attachment: PHOENIX-3351_WIP.patch
[~maryannxue] Here is the WIP patch fixes upserts on tenant tables and view or
local indexes. Removed the duplicate code and reusing the code from phoenix.
Please review. Will first fix phoenix level changes if the patch is fine.
As you suggested I have tried to implement using system columns supported
provided by calcite. But I have not found proper code path how to extend tenant
and view index columns as system columns. Instead I have found couple of things
like 1) Join#getSystemFieldList prefixing the system fields to the row type.
But I think this is only for Join queries.
2) SqlValidatorImpl#getCustomStarExpansion can expand star into a way required
by us. But it seems helpful for upsert select * from table kind of queries.
Please let me know if I missing anything for supporting system columns/fields.
> Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant
> specific tables
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-3351
> URL: https://issues.apache.org/jira/browse/PHOENIX-3351
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Attachments: PHOENIX-3351_WIP.patch
>
>
> While running UDF IT tests came across this TODO which is necessary to
> implement for tenant specific, local or view indexes tests to pass.
> {noformat}
> // TODO TenantId, ViewIndexId, UpdatableViewColumns
> final List<PColumn> mappedColumns =
> targetTable.tableMapping.getMappedColumns();
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
