Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/223#discussion_r90119141
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
 ---
    @@ -899,9 +899,6 @@ public static boolean isConvertible(Aggregate input) {
             if (input.getGroupSets().size() > 1)
                 return false;
             
    -        if (input.containsDistinctCall())
    --- End diff --
    
    One minor nit, would you mind add check for other distinct functions? coz 
we don't support SUM DISTINCT yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to