[
https://issues.apache.org/jira/browse/PHOENIX-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706605#comment-15706605
]
ASF GitHub Bot commented on PHOENIX-3488:
-----------------------------------------
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/223#discussion_r90119141
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/rules/PhoenixConverterRules.java
---
@@ -899,9 +899,6 @@ public static boolean isConvertible(Aggregate input) {
if (input.getGroupSets().size() > 1)
return false;
- if (input.containsDistinctCall())
--- End diff --
One minor nit, would you mind add check for other distinct functions? coz
we don't support SUM DISTINCT yet.
> Support COUNT(DISTINCT x) in Phoenix-Calcite Integration
> --------------------------------------------------------
>
> Key: PHOENIX-3488
> URL: https://issues.apache.org/jira/browse/PHOENIX-3488
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Eric Lomore
> Assignee: Eric Lomore
> Labels: calcite
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)