[
https://issues.apache.org/jira/browse/PHOENIX-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723107#comment-15723107
]
Thomas D'Silva edited comment on PHOENIX-3442 at 12/5/16 7:28 PM:
------------------------------------------------------------------
[~jamestaylor]
Thanks for the review. I have attached an updated patch. I modified the code so
that it stores the offsets as short values if the maxoffset <= Short.MAX_VALUE
and maxoffset >= Short.MIN_VALUE.
I also created a new serialization type IMMUTABLE_SERIALIZATION_VERSION which
does not use separator bytes. I added some tests for this new serialization in
ArrayConstructorExpressionTest.
We don't need to support appending or prepending to an array with this new
serialization since it stores immutable data.
was (Author: tdsilva):
[~jamestaylor]
Thanks for the review. I have attached an updated patch. I modified the code so
that it stores the offsets as short values if the maxoffset <= Short.MAX_VALUE
and maxoffset >= Short.MIN_VALUE.
I also created a new serialization type IMMUTABLE_SERIALIZATION_VERSION which
does not use separator bytes. I added some tests for this new serialization in
ArrayConstructorExpressionTest.
We don't need to appending or prepinding to an array with this new
serialization since it stores immutable data.
> Support null when columns have default values for immutable tables with
> encoding scheme COLUMNS_STORED_IN_SINGLE_CELL
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3442
> URL: https://issues.apache.org/jira/browse/PHOENIX-3442
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-3442-v2.patch, PHOENIX-3442.patch
>
>
> Comments from [~jamestaylor]:
> The way we differentiate a null value now is by the value being an empty byte
> array (explicitly set to null) versus not being present (in which case we use
> the default value).
> This is encapsulated in the DefaultValueExpression.
> We'll need to tweak our encoding for this.
> One way would be to use a negative number for the offset.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
