Github user twdsilva commented on the pull request:

    
https://github.com/apache/phoenix/commit/11c0c3b7b40f34f130554363a85ef0de7edd31a3#commitcomment-20281656
  
    After the rebase the following assert in 
AlterTableIT.testAddingColumnsToTablesAndViewsWithEncodedColumns was failing.
    
    ```
    assertNull("A view should always have the column qualifier counter as 
null", view.getEncodedCQCounter().getNextQualifier(DEFAULT_COLUMN_FAMILY));
    ```
    
     This was because the rebase when you add a column or update a table 
property, the new PTable is sent from the server to the client and this is 
added to the client cache. Previously we just used to modify the PTable on the 
client side. 
    
    The createFromProto code to deserialize the PTable was setting the 
encodedColumnQualifierCounter to  new EncodedCQCounter() (even if the table is 
a view) which caused the assert to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to