[
https://issues.apache.org/jira/browse/PHOENIX-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782712#comment-15782712
]
Hadoop QA commented on PHOENIX-3134:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12844909/PHOENIX-3134_v1.patch
against master branch at commit 07f92732f9c6d2d9464012cebeb4cefc10da95d5.
ATTACHMENT ID: 12844909
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
42 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ static final Option binaryEncodingOption = new Option("b",
"binaryEncoding", true, "Specifies binary encoding");
+ public static final String UPLOAD_BINARY_DATA_TYPE_ENCODING =
"phoenix.upload.binaryDataType.encoding";
+ public static final String DEFAULT_UPLOAD_BINARY_DATA_TYPE_ENCODING =
"BASE64"; // for backward compatibility, till
+
// 4.10, psql and CSVBulkLoad
+
// expects binary data to be base 64
+
props.setProperty(QueryServices.UPLOAD_BINARY_DATA_TYPE_ENCODING,
execCmd.binaryEncoding);
+ throw new IllegalDataException("Unsupported encoding
\"" + binaryEncoding + "\"");
+ throw new IllegalDataException("Unsupported encoding \"" +
binaryEncoding + "\"");
+ R csvRecordWithInvalidType =
createRecord("123,NameValue,42,1:2:3,NotABoolean,"+encodedBinaryData);
+
getUpsertExecutor(DriverManager.getConnection(getUrl(),info)).execute(createRecord(123L,
"NameValue", 42,
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/711//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/711//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/711//console
This message is automatically generated.
> varbinary fields bulk load difference between MR/psql and upserts
> -----------------------------------------------------------------
>
> Key: PHOENIX-3134
> URL: https://issues.apache.org/jira/browse/PHOENIX-3134
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Sergey Soldatov
> Assignee: Ankit Singhal
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3134.patch, PHOENIX-3134_v1.patch
>
>
> At the moment we have strange difference between how MR/psql upload and
> upsert handles varbinary. MR/ psql expects that it's base64 encoded whereas
> upsert takes input as a string. Should we add an option to load it as a plain
> data or base64 in MR/psql?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
