[
https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797332#comment-15797332
]
Kevin Liew commented on PHOENIX-3413:
-------------------------------------
If the value is not null, the data-type should not be null or can be derived
from the value. Please review [~jamestaylor]
> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
> Key: PHOENIX-3413
> URL: https://issues.apache.org/jira/browse/PHOENIX-3413
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.9.1
> Reporter: Ted Yu
> Assignee: Kevin Liew
> Priority: Minor
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3413.patch
>
>
> {code}
> if (maxLength == null) {
> maxLength = type == null || !type.isFixedWidth() ? null :
> type.getMaxLength(value);
> }
> {code}
> The null check for type is ineffective - type is de-referenced in various
> places prior to the above check.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
