[
https://issues.apache.org/jira/browse/PHOENIX-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812504#comment-15812504
]
Maryann Xue commented on PHOENIX-3579:
--------------------------------------
Thank you very much for the initial patch, [~kliew]! But I think there was some
misunderstanding here. First of all, I think there should have been an example
here: "UPSERT INTO T VALUES(?,?)" where "T" has three or more columns and the
missing columns from UPSERT are nullable.
1. This is supposed to be fixed in Calcite, and I assume only in Calcite.
Please see CALCITE-1510. Do the test cases that cannot pass throw Calcite
validation exceptions?
2. PHOENIX-3357 should be fixed already. Sorry that I forgot to mark it
resolved. Let me know if there are still issues.
3. [[email protected]] had run into problems with existing Phoenix test
cases, so it would be nice if [~rajeshbabu] could point out which tests can
reproduce this issue. Basically any change made to non-calcite files should be
made into master branch, so we'd like to avoid unnecessary changes to the
existing test files. Alternatively you could add tests to CalciteIT,
CalciteDMLIT, CalciteDDLIT, etc, and you don't need to worry about checking in
to master branch.
> INSERT/UPSERT should allow values less than number of columns in
> Calcite-Phoenix
> --------------------------------------------------------------------------------
>
> Key: PHOENIX-3579
> URL: https://issues.apache.org/jira/browse/PHOENIX-3579
> Project: Phoenix
> Issue Type: Bug
> Reporter: Kevin Liew
> Assignee: Kevin Liew
> Labels: calcite
> Attachments: PHOENIX-3579.2.patch, PHOENIX-3579.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
