[
https://issues.apache.org/jira/browse/PHOENIX-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828692#comment-15828692
]
James Taylor commented on PHOENIX-3519:
---------------------------------------
Thanks for the patch, [~tdsilva]. Here's some feedback:
- Is this because we'll allocate a new slot for the new column and they won't
like up based on name now? I think we should explain that.
{code}
+ // For the non-diverged view, adding the column VIEW_COL2 will end
up changing its ordinal position in the view.
{code}
- Why is this change needed?
{code}
- if (table == null || table.getType() == PTableType.VIEW ||
table.isTransactional()) {
+ if (table == null || table.getType() == PTableType.VIEW /*||
table.isTransactional()*/) {
{code}
- Is this only when we store everything in a single KeyValue?
{code}
+ if (isImmutableRows) {
+ // force store nulls to true so delete markers aren't used
+ storeNulls = true;
+ tableProps.put(PhoenixDatabaseMetaData.STORE_NULLS,
Boolean.TRUE);
+ }
+
{code}
- Do we have a unit test for usage of NONE?
{code}
+ if ("NONE".equalsIgnoreCase(strValue)) {
+ return 0;
+ }
{code}
> Add COLUMN_ENCODED_BYTES table property
> ---------------------------------------
>
> Key: PHOENIX-3519
> URL: https://issues.apache.org/jira/browse/PHOENIX-3519
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3519.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
