[
https://issues.apache.org/jira/browse/PHOENIX-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas D'Silva updated PHOENIX-3519:
------------------------------------
Attachment: PHOENIX-3519-v2.patch
[~jamestaylor]
Thanks for the feedback, I have attached a v2 patch with review changes.
When we add a column that already exists in a child view to the base table it
is propagated to child views add the existing column in the child view ordinal
position might change to match that of the base table.
For tables with encoded column qualifiers we don't allow users to add an
existing view column to the base table.
I changed the default behavior to not use encoded column qualifier in this
patch (and reverted this change in PHOENIX-3586)
I had to make the following change in MetadataClient.createTable as the
PostDDLCompiler plan was not being run for transactional tables so stats were
not available after a transnational table was created.
I changed the check to be
{code}
if (isImmutableRows && encodingScheme != NON_ENCODED_QUALIFIERS) {
// force store nulls to true so delete markers aren't used
storeNulls = true;
tableProps.put(PhoenixDatabaseMetaData.STORE_NULLS,
Boolean.TRUE);
}
{code}
I have added a unit test for "NONE".
> Add COLUMN_ENCODED_BYTES table property
> ---------------------------------------
>
> Key: PHOENIX-3519
> URL: https://issues.apache.org/jira/browse/PHOENIX-3519
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3519.patch, PHOENIX-3519-v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
