[ 
https://issues.apache.org/jira/browse/PHOENIX-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847886#comment-15847886
 ] 

Samarth Jain commented on PHOENIX-3444:
---------------------------------------

The idea of having new/old methods was really to help us just remove code when 
we rollout our next major release. The alternative was to have code with 
branches on isNewClient/isOldClient which would have made it a bit ugly, IMHO. 
I also looked at seeing whether I can just getaway with not storing the 
coveredColumnsMap for non-encoded tables. It turns out, the indexmaintainer 
already tracks this information in two datastructures - coveredColumns set and 
indexedQualifiers list. The coveredColumnsMap is now just a single place where 
we track this. I can make coveredColumns set deprecated just like I did for 
indexedQualifiersList and dataTableLocalIndexFamilyMap since the information is 
already available in the newly added coveredColumnsMap. 

> Make changes to IndexMaintainer backward compatible
> ---------------------------------------------------
>
>                 Key: PHOENIX-3444
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3444
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3444.patch
>
>
> Currently, the changes made on the encodecolumns2 branch in the 
> IndexMaintainer class are not backward compatible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to