[
https://issues.apache.org/jira/browse/PHOENIX-3444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samarth Jain updated PHOENIX-3444:
----------------------------------
Attachment: PHOENIX-3444_v3.patch
Updated patch based on feedback by, [~jamestaylor]. Below is the summary of
changes:
1) Got rid of a couple of member variables since the information is already
contained in the new member variable - coveredColumnsMap
2) Got rid of having checks for old and new client since now both new and old
index maintainers can use the buildUpdate and buildDelete methods.
3) If table is non-encoded, then we don't need to serialize the index table
qualifiers for covered columns. For encoded tables we need to since the index
table qualifiers in this case are not derivable from data table qualifiers.
4) Removed the need for tracking coverdColumnsInfo since the information in
coveredColumnsMap is enough.
5) Still need to track indexedColumnInfo since we use this information to
detect whether a column drop should result in dropping the index or whether a
view has all columns needed by an index, etc. The information contained in
indexedColumns is not enough since for immutable encoded tables, an indexed
column is the packed cell where as we need the column name and column family of
a qualifier packed in that cell.
> Make changes to IndexMaintainer backward compatible
> ---------------------------------------------------
>
> Key: PHOENIX-3444
> URL: https://issues.apache.org/jira/browse/PHOENIX-3444
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-3444.patch, PHOENIX-3444_v3.patch
>
>
> Currently, the changes made on the encodecolumns2 branch in the
> IndexMaintainer class are not backward compatible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
