[ https://issues.apache.org/jira/browse/PHOENIX-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860381#comment-15860381 ]
Hadoop QA commented on PHOENIX-3659: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12851937/PHOENIX-3659.001.patch against master branch at commit 41d6349bd50de1ef13a52a8b146c01b504e60aeb. ATTACHMENT ID: 12851937 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation, build, or dev patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 42 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SubqueryIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ArithmeticQueryIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ServerExceptionIT ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RenewLeaseIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/760//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/760//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/760//console This message is automatically generated. > Remove transitive OWASP esapi dependency > ---------------------------------------- > > Key: PHOENIX-3659 > URL: https://issues.apache.org/jira/browse/PHOENIX-3659 > Project: Phoenix > Issue Type: Task > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Blocker > Fix For: 4.10.0 > > Attachments: PHOENIX-3659.001.patch > > > HBase accidentally let OWASP's ESAPI artifact slip into a few release which > is not allowed (as there are GPL deps). > This was resolved in 1.1.6 and 1.2.3. A trivial fix would be to upgrade the > 1.1 and 1.2 branches to these versions, but I don't know if there are other > implications to doing that.. > I'm not sure if there are runtime concerns if we just omit those > dependencies. Would have to look at the suite of reverts that came in via > HBASE-16317 to see if any of them would actually affect us in phoenix-landia. -- This message was sent by Atlassian JIRA (v6.3.15#6346)