[
https://issues.apache.org/jira/browse/PHOENIX-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864631#comment-15864631
]
Hadoop QA commented on PHOENIX-3660:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12852425/PHOENIX-3660.patch
against master branch at commit 8f2d0fbc5e4d14dc04c2491d78cea1a4b93be0b7.
ATTACHMENT ID: 12852425
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String ddl = "CREATE TABLE " + (notExists ? "IF NOT EXISTS " :
"") + metricTableName + "(metricId INTEGER NOT NULL, metricVal DOUBLE,
CONSTRAINT PK PRIMARY KEY(metricId))"
+ + " APPEND_ONLY_SCHEMA = true, UPDATE_CACHE_FREQUENCY=1,
AUTO_PARTITION_SEQ=" + metricIdSeqTableName;
+ viewDDL = "ALTER VIEW " + viewName + " ADD " + (notExists ? "IF
NOT EXISTS" : "") + " tagName varchar";
+ return addColumn(table, columnDefs,
ImmutableListMultimap.<String,Pair<String,Object>>of(), statement.ifNotExists(),
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryTimeoutIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/765//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/765//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/765//console
This message is automatically generated.
> Don't pass statement properties while adding columns to a table that already
> exists that had APPEND_ONLY_SCHEMA=true
> --------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3660
> URL: https://issues.apache.org/jira/browse/PHOENIX-3660
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3660.patch
>
>
> If the table has APPEND_ONLY_SCHEMA set to true, we should only add new
> columns and ignore any supplied properties.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
