[
https://issues.apache.org/jira/browse/PHOENIX-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870837#comment-15870837
]
Hadoop QA commented on PHOENIX-3684:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12853138/PHOENIX-3684.001.patch
against master branch at commit c3b16cef5de15df059b5c979a1b54110e5b0ca00.
ATTACHMENT ID: 12853138
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
43 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (!currentUser.hasKerberosCredentials() ||
!isSameName(currentUser.getUserName(), principal)) {
+ static boolean isSameName(String currentName, String newName, String
hostname) throws IOException {
+ newName =
org.apache.hadoop.security.SecurityUtil.getServerPrincipal(newName, hostname);
+ assertTrue(ConnectionInfo.isSameName("user/[email protected]",
"user/[email protected]"));
+ assertTrue(ConnectionInfo.isSameName("user/[email protected]",
"user/[email protected]", "localhost"));
+ assertFalse(ConnectionInfo.isSameName("user/[email protected]",
"user/[email protected]", "localhost"));
+ assertFalse(ConnectionInfo.isSameName("[email protected]",
"user/[email protected]", "localhost"));
+
connections.add(ConnectionInfo.create(url1).normalize(ReadOnlyProps.EMPTY_PROPS,
EMPTY_PROPERTIES));
+
connections.add(ConnectionInfo.create(url1).normalize(ReadOnlyProps.EMPTY_PROPS,
EMPTY_PROPERTIES));
+
connections.add(ConnectionInfo.create(url2).normalize(ReadOnlyProps.EMPTY_PROPS,
EMPTY_PROPERTIES));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.RoundRobinResultIteratorWithStatsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/772//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/772//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/772//console
This message is automatically generated.
> ConnectionQueryServices connection leak on principal with "_HOST"
> -----------------------------------------------------------------
>
> Key: PHOENIX-3684
> URL: https://issues.apache.org/jira/browse/PHOENIX-3684
> Project: Phoenix
> Issue Type: Bug
> Reporter: Arpit Gupta
> Assignee: Josh Elser
> Priority: Blocker
> Fix For: 4.9.1, 4.10.0
>
> Attachments: PHOENIX-3684.001.patch
>
>
> Through some internal testing, we found that Ambari's use of Phoenix to host
> metrics data was leaking ConnectionQueryServices (and thus HConnections and
> ZK connections), ultimately running into ZK's rate limiting maxClientCnxns.
> After a bit of digging around (and revisiting the old issues around this
> topic PHOENIX-3607, PHOENIX-3611, etc), I finally realized that the logic in
> ConnectionInfo was simply not correctly handling the {{_HOST}} special string
> in the principal (that UGI will replace with the FQDN for the current host).
> This resulted in Phoenix repeatedly re-logging in the user when they created
> a new Connection instead of using the UGI current user, leaking another set
> of connections.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
