[
https://issues.apache.org/jira/browse/PHOENIX-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883983#comment-15883983
]
Kevin Liew commented on PHOENIX-3690:
-------------------------------------
I suggest we set PhoenixSchema.typeFactory and
PhoenixTable.initializerExpressionFactory in the constructor and make them
immutable. We can make the InitializerExpressionFactory a nested class so it
becomes more readable.
{code:java}
initializerExpressionFactory = typeFactory == null ? null : new
PhoenixTableInitializerExpressionFactory(typeFactory);
{code}
There is some common code in PhoenixPrepareImpl that can be made into a private
method.
> Support declaring default values in Phoenix-Calcite
> ---------------------------------------------------
>
> Key: PHOENIX-3690
> URL: https://issues.apache.org/jira/browse/PHOENIX-3690
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Attachments: PHOENIX-3690.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
