[ 
https://issues.apache.org/jira/browse/PHOENIX-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941374#comment-15941374
 ] 

Enis Soztutar commented on PHOENIX-3062:
----------------------------------------

Checked the patch, seems the right approach. 
You should also delete PhoenixMetricsSink since it is not needed anymore. Also 
rename TraceMetricSource because it is not a MetricSource anymore. 
There is a couple of debug statements lying around. 

> JMXCacheBuster restarting the metrics system causes PhoenixTracingEndToEndIT 
> to hang
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3062
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3062
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Karan Mehta
>             Fix For: 4.11.0
>
>         Attachments: phoenix-3062_v1.patch, PHOENIX-3062_v2.patch
>
>
> With some recent fixes in the hbase metrics system, we are now affectively 
> restarting the metrics system (in HBase-1.3.0, probably not affecting 1.2.0). 
> Since we use a custom sink in the PhoenixTracingEndToEndIT, restarting the 
> metrics system loses the registered sink thus causing a hang. 
> We need a fix in HBase, and Phoenix so that we will not restart the metrics 
> during tests. 
> Thanks to [~sergey.soldatov] for analyzing the initial root cause of the 
> hang. 
> See HBASE-14166 and others. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to