[
https://issues.apache.org/jira/browse/PHOENIX-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943662#comment-15943662
]
Josh Elser commented on PHOENIX-3748:
-------------------------------------
[~sunoj72], your change makes sense here, but I think it's not 100% ready for
commit.
If you look down at the Java command, your change would ultimately cause two
instances of {{HBASE_CONF_DIR}} to be added to the classpath which is
unnecessary.
I'm trying to piece together what is exactly necessary. Is there a reason that,
when {{HBASE_CONF_DIR}} isn't set, {{phoenix_utils.current_dir}} must be added
to the classpath? I see that the log4j.properties file is referenced
explicitly. I think that means we don't need to have {{hbase_config_path}}
added to the classpath.
Might you be able to confirm that, Soonho?
> sqlline.py, sqlline-thin.py are using the wrong variables.
> ----------------------------------------------------------
>
> Key: PHOENIX-3748
> URL: https://issues.apache.org/jira/browse/PHOENIX-3748
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.6.0, 4.8.0
> Reporter: Soonho Kim
> Priority: Trivial
> Labels: patch
> Attachments: PHOENIX-3748.patch
>
>
> It seems that the hbase_config_path variable in the sqlline.py and
> sqlline-thin.py scripts, are looking for invalid values.
> These variables should use the value "phoenix_utils.hbase_conf_dir" instead
> of "phoenix_utils.current_dir".
> -hbase_config_path = os.getenv('HBASE_CONF_DIR', phoenix_utils.current_dir)
> +hbase_config_path = os.getenv('HBASE_CONF_DIR', phoenix_utils.hbase_conf_dir)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
