Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/236#discussion_r109749299
--- Diff: phoenix-queryserver/pom.xml ---
@@ -147,6 +147,14 @@
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.phoenix</groupId>
+ <artifactId>phoenix-queryserver-loadbalancer</artifactId>
--- End diff --
I'm pretty sure I put this on the last PR (the one you closed). I think
it's a bad idea to strongly tie PQS to the load balancer. You should make an
interface in PQS which defines what it needs to know and then include the load
balancer impl optionally (e.g. via ServiceLoader).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
