[
https://issues.apache.org/jira/browse/PHOENIX-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957645#comment-15957645
]
Hadoop QA commented on PHOENIX-3756:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12862143/PHOENIX-3756.008.patch
against master branch at commit 2c53fc9856ba3770e742c0729cdef9b2c0181873.
ATTACHMENT ID: 12862143
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static final TableName SYSTEM_CATALOG_HBASE_TABLE_NAME =
TableName.valueOf(SYSTEM_CATALOG_NAME);
+ public static final TableName SYSTEM_MUTEX_HBASE_TABLE_NAME =
TableName.valueOf(SYSTEM_MUTEX_NAME);
+ if
(!Iterables.isEmpty(Iterables.filter(Throwables.getCausalChain(e),
AccessDeniedException.class))) {
+ logger.warn("Could not check for
Phoenix SYSTEM tables, assuming they exist and are properly configured");
+
checkClientServerCompatibility(SchemaUtil.getPhysicalName(SYSTEM_CATALOG_NAME_BYTES,
getProps()).getName());
+ return
Lists.newArrayList(admin.listTableNames(QueryConstants.SYSTEM_SCHEMA_NAME +
"\\..*"));
+ private static final PhoenixIOException PHOENIX_IO_EXCEPTION = new
PhoenixIOException(new Exception("Test exception"));
+
when(cqs.getSystemTableNames(any(HBaseAdmin.class))).thenReturn(Collections.<TableName>
emptyList());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
at
org.apache.ambari.server.state.ServiceComponentTest.testAddAndGetServiceComponentHosts(ServiceComponentTest.java:244)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/825//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/825//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/825//console
This message is automatically generated.
> Users lacking ADMIN on 'SYSTEM' HBase namespace can't connect to Phoenix
> ------------------------------------------------------------------------
>
> Key: PHOENIX-3756
> URL: https://issues.apache.org/jira/browse/PHOENIX-3756
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3756.001.patch, PHOENIX-3756.002.patch,
> PHOENIX-3756.003.patch, PHOENIX-3756.004.patch, PHOENIX-3756.005.patch,
> PHOENIX-3756.006.patch, PHOENIX-3756.007.patch, PHOENIX-3756.008.patch
>
>
> Follow-on from PHOENIX-3652:
> The fix provided in PHOENIX-3652 addressed the default situation where users
> would need ADMIN on the default HBase namespace. However, when
> {{phoenix.schema.isNamespaceMappingEnabled=true}} and Phoenix creates its
> system tables in the {{SYSTEM}} HBase namespace, unprivileged users (those
> lacking ADMIN on {{SYSTEM}}) still cannot connect to Phoenix.
> The root-cause is essentially the same: the code tries to fetch the
> {{NamespaceDescriptor}} for the {{SYSTEM}} namespace which requires the ADMIN
> permission.
> https://github.com/apache/phoenix/blob/8093d10f1a481101d6c93fdf0744ff15ec48f4aa/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L1017-L1037
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
