[
https://issues.apache.org/jira/browse/PHOENIX-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977112#comment-15977112
]
Hadoop QA commented on PHOENIX-3800:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12864294/PHOENIX-3800.patch
against master branch at commit 5bd7f79b51309505a19f854d05cb000f5cd1eb9f.
ATTACHMENT ID: 12864294
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ initATableValues(ATABLE_NAME, tenantId, saltTable ? null : splits,
null, ts-1, getUrl(), saltTable ? "salt_buckets = 2" : null);
+ ensureTableCreated(getUrl(), CUSTOM_ENTITY_DATA_FULL_NAME,
CUSTOM_ENTITY_DATA_FULL_NAME, null, ts-1, saltTable ? "salt_buckets = 2" :
null);
+ projectedColumns.add(column.getPosition() == i +
posOff ? column : new PColumnImpl(column, i + posOff));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/836//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/836//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/836//console
This message is automatically generated.
> NPE when doing UPSERT SELECT into salted tables
> -----------------------------------------------
>
> Key: PHOENIX-3800
> URL: https://issues.apache.org/jira/browse/PHOENIX-3800
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.10.0
> Reporter: Eiichi Sato
> Attachments: PHOENIX-3800.patch
>
>
> We run into NPE when doing UPSERT SELECT into salted tables, client and
> server both running 4.10.0 release. Here is a minimal reproducer and the
> stack trace on the client side.
> {code}
> create table test (id varchar not null primary key, a integer, b integer)
> salt_buckets = 2;
> upsert into test (id, b) select id, 1 from test;
> {code}
> {code}
> java.lang.NullPointerException: at index 2
> at
> com.google.common.collect.ObjectArrays.checkElementNotNull(ObjectArrays.java:191)
> at
> com.google.common.collect.ImmutableList.construct(ImmutableList.java:320)
> at
> com.google.common.collect.ImmutableList.copyOf(ImmutableList.java:290)
> at org.apache.phoenix.schema.PTableImpl.init(PTableImpl.java:534)
> at org.apache.phoenix.schema.PTableImpl.<init>(PTableImpl.java:408)
> at
> org.apache.phoenix.schema.PTableImpl.makePTable(PTableImpl.java:297)
> at
> org.apache.phoenix.compile.UpsertCompiler.compile(UpsertCompiler.java:684)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableUpsertStatement.compilePlan(PhoenixStatement.java:611)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableUpsertStatement.compilePlan(PhoenixStatement.java:597)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:351)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:341)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:339)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1511)
> at sqlline.Commands.execute(Commands.java:822)
> at sqlline.Commands.sql(Commands.java:732)
> at sqlline.SqlLine.dispatch(SqlLine.java:813)
> at sqlline.SqlLine.begin(SqlLine.java:686)
> at sqlline.SqlLine.start(SqlLine.java:398)
> at sqlline.SqlLine.main(SqlLine.java:291)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
