[ 
https://issues.apache.org/jira/browse/PHOENIX-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979654#comment-15979654
 ] 

Maryann Xue commented on PHOENIX-3715:
--------------------------------------

Although we are ignoring explain plan differences, a lot of compilation checks 
are still valid in Calcite-Phoenix tests, in which we check the {{QueryPlan}} 
object.
I believe most of these mismatches occur with compile-time and esp. parsing and 
validation errors, which now all go through Calcite instead of Phoenix. Two 
solutions maybe:
1) change each test case to match the new error code.
2) catch the Calcite exception and throw the corresponding Phoenix exception.
Approach 2 would require more effort and might not be worth it I think.

> Calcite-Phoenix exceptions do not match error code or specific SQLException 
> sub-classes
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3715
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3715
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Maryann Xue
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Minor
>              Labels: calcite
>         Attachments: PHOENIX-3715.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to