[
https://issues.apache.org/jira/browse/PHOENIX-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009027#comment-16009027
]
Hadoop QA commented on PHOENIX-3823:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12867899/PHOENIX-3823.patch
against master branch at commit 442d8eb29f1f73fd104a323d9aa77f3a4ccfd8d1.
ATTACHMENT ID: 12867899
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String createQry = "create table "+tableName+" (k VARCHAR PRIMARY
KEY, v1 VARCHAR, v2 VARCHAR)"
+ "CREATE VIEW MY_VIEW (v43 VARCHAR) AS SELECT * FROM
"+tableName+" WHERE v1 = 'value1'";
+ String schemaNameStr =
dataTable.getSchemaName()==null?null:dataTable.getSchemaName().getString();
+ String tableNameStr =
dataTable.getTableName()==null?null:dataTable.getTableName().getString();
+ throw new ColumnNotFoundException(schemaNameStr,
tableNameStr,null, WildcardParseNode.INSTANCE.toString());
+ String schemaNameStr =
table.getSchemaName()==null?null:table.getSchemaName().getString();
+ String tableNameStr =
table.getTableName()==null?null:table.getTableName().getString();
+ throw new ColumnNotFoundException(schemaNameStr, tableNameStr,
null, ref.getColumn().getName().getString());
+ return new ColumnFamilyNotFoundException(info.getSchemaName(),
info.getTableName(), info.getFamilyName());
+ logger.debug("Reloading table "+
e.getTableName()+" data from server");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpdateCacheParallelIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/861//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/861//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/861//console
This message is automatically generated.
> Force cache update on MetaDataEntityNotFoundException
> ------------------------------------------------------
>
> Key: PHOENIX-3823
> URL: https://issues.apache.org/jira/browse/PHOENIX-3823
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 4.10.0
> Reporter: James Taylor
> Assignee: Maddineni Sukumar
> Fix For: 4.11.0
>
> Attachments: PHOENIX-3823.patch
>
>
> When UPDATE_CACHE_FREQUENCY is used, clients will cache metadata for a period
> of time which may cause the schema being used to become stale. If another
> client adds a column or a new table or view, other clients won't see it. As a
> result, the client will get a MetaDataEntityNotFoundException. Instead of
> bubbling this up, we should retry after forcing a cache update on the tables
> involved in the query.
> The above works well for references to entities that don't yet exist.
> However, we cannot detect when some entities are referred to which no longer
> exists until the cache expires. An exception is if a physical table is
> dropped which would be detected immediately, however we would allow queries
> and updates to columns which have been dropped until the cache entry expires
> (which seems like a reasonable tradeoff IMHO. In addition, we won't start
> using indexes on tables until the cache expires.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
