[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020440#comment-16020440 ]
Rahul Shrivastava commented on PHOENIX-3655: -------------------------------------------- [~jamestaylor] Phoenix metrics provide Tablename etc but not original intended queries. Please refer to example json that we get from existing phoenix runtime metrics. https://github.com/apache/phoenix/pull/242#issuecomment-301637175 The global metrics has no query specific info. My suggestion is at statement close, or connection close, pass the metrics info to a backend sink . This code can be sitting in phoenix driver. This way we can process the info by post processing log files/external sink, and you can answer the questions like 1. top 10 queries by most time/ most bytes fetched etc. The is same we tried to do in this patch for PQS but the natural place for such a code to reside is on the driver. thanks Rahul > Metrics for PQS > --------------- > > Key: PHOENIX-3655 > URL: https://issues.apache.org/jira/browse/PHOENIX-3655 > Project: Phoenix > Issue Type: New Feature > Affects Versions: 4.8.0 > Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98 > Reporter: Rahul Shrivastava > Assignee: Rahul Shrivastava > Fix For: 4.9.0 > > Attachments: MetricsforPhoenixQueryServerPQS.pdf > > Original Estimate: 240h > Remaining Estimate: 240h > > Phoenix Query Server runs a separate process compared to its thin client. > Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix > driver level. We need the following > 1. For every jdbc statement/prepared statement/ run by PQS , we need > capability to collect metrics at PQS level and push the data to external sink > i.e. file, JMX , other external custom sources. > 2. Besides this global metrics could be periodically collected and pushed to > the sink. > 2. PQS can be configured to turn on metrics collection and type of collect ( > runtime or global) via hbase-site.xml > 3. Sink could be configured via an interface in hbase-site.xml. > All metrics definition https://phoenix.apache.org/metrics.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)