[
https://issues.apache.org/jira/browse/PHOENIX-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025628#comment-16025628
]
Hadoop QA commented on PHOENIX-3865:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12869960/PHOENIX-3865.patch
against master branch at commit 5f9cf15e272fc9d92a3165753ac2157396851bd6.
ATTACHMENT ID: 12869960
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static void insertRow(Connection conn, String tableName,
String uri, int appcpu, int id) throws SQLException {
+ PreparedStatement statement = conn.prepareStatement("UPSERT INTO " +
tableName + "(id, uri, appcpu) values (?,?,?)");
+ String ddl = " create table " + tableName + "(tgb_id integer NOT
NULL,utc_date_epoch integer NOT NULL,tgb_name varchar(40),ack_success_count
integer" +
+ ",ack_success_one_ack_count integer, CONSTRAINT pk_tgb_counter
PRIMARY KEY(tgb_id, utc_date_epoch))";
+ String query = "SELECT tgb_id, tgb_name, (utc_date_epoch/10)*10 AS
utc_epoch_hour,SUM(ack_success_count + ack_success_one_ack_count) AS
ack_tx_sum" +
+ String ddl = " create table " + tableName + "(id varchar primary
key,v1 boolean, v2 integer, v3 integer)";
+ PreparedStatement stmt = conn.prepareStatement("UPSERT INTO " +
tableName + "(id,v2,v3) VALUES(?,?,?)");
+ ResultSet rs = conn.createStatement().executeQuery("SELECT v1, v2,
v3 from " + tableName + " group by " + gb);
+ assertTrue(e.getMessage().contains("Aggregate expressions may not
be used in GROUP BY"));
+ conn.createStatement().execute("UPSERT INTO " + tableName + "
VALUES('1', 'val', 100, 'a', ARRAY ['b'], 1, 2)");
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.execute.PartialCommitIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/907//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/907//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/907//console
This message is automatically generated.
> IS NULL does not return correct results when first column family not filtered
> against
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-3865
> URL: https://issues.apache.org/jira/browse/PHOENIX-3865
> Project: Phoenix
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: James Taylor
> Attachments: PHOENIX-3865.patch, PHOENIX-3865-wip.patch
>
>
> I'm using poor a poor man's method for sampling. In the following table, I
> write a non-null value to COLB with a probability of 0.001.
> {code}
> create table test (mykey integer not null primary key, A.COLA integer, B.COLB
> integer) IMMUTABLE_ROWS=true, STORE_NULL=false, IMMUTABLE_STORAGE_SCHEME =
> ONE_CELL_PER_COLUMN, DISABLE_WAL=true
> {code}
> Then:
> {code}
> 0: jdbc:phoenix:localhost> select count(*) from test;
> +-----------+
> | COUNT(1) |
> +-----------+
> | 10000000 |
> +-----------+
> 1 row selected (8.95 seconds)
> 0: jdbc:phoenix:localhost> select count(*) from test where B.COLB is not null;
> +-----------+
> | COUNT(1) |
> +-----------+
> | 10054 |
> +-----------+
> 1 row selected (0.023 seconds)
> 0: jdbc:phoenix:localhost> select count(*) from test where B.COLB is null;
> +-----------+
> | COUNT(1) |
> +-----------+
> | 0 |
> +-----------+
> 1 row selected (0.022 seconds)
> {code}
> Last statement should have returned 10000000-10054 = 9989946 rows.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
