[
https://issues.apache.org/jira/browse/PHOENIX-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027380#comment-16027380
]
Hadoop QA commented on PHOENIX-3834:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12870202/PHOENIX-3834_v2.patch
against master branch at commit a21689954d611d287d15ac8cd1eac01bdadef26a.
ATTACHMENT ID: 12870202
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
45 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (PK1 INTEGER NOT NULL PRIMARY KEY, KV1
VARCHAR) USE_STATS_FOR_QUERY_PLAN = false";
+ "SELECT USE_STATS_FOR_QUERY_PLAN FROM SYSTEM.CATALOG WHERE
TABLE_NAME = ? AND COLUMN_NAME IS NULL AND COLUMN_FAMILY IS NULL AND TENANT_ID
IS NULL";
+ .isNamespaceMappingEnabled(PTableType.SUBQUERY,
connection.getQueryServices().getProps()), null, false,
ImmutableStorageScheme.ONE_CELL_PER_COLUMN,
QualifierEncodingScheme.NON_ENCODED_QUALIFIERS,
PTable.EncodedCQCounter.NULL_COUNTER, true);
+ left.getAutoPartitionSeqName(), left.isAppendOnlySchema(),
ONE_CELL_PER_COLUMN, NON_ENCODED_QUALIFIERS,
PTable.EncodedCQCounter.NULL_COUNTER, left.useStatsForQueryPlan());
+ table.getIndexDisableTimestamp(), table.isNamespaceMapped(),
table.getAutoPartitionSeqName(), table.isAppendOnlySchema(),
table.getImmutableStorageScheme(), table.getEncodingScheme(),
table.getEncodedCQCounter(), table.useStatsForQueryPlan());
+ table.getUpdateCacheFrequency(),
table.getIndexDisableTimestamp(), table.isNamespaceMapped(),
table.getAutoPartitionSeqName(), table.isAppendOnlySchema(),
table.getImmutableStorageScheme(), table.getEncodingScheme(), cqCounter,
table.useStatsForQueryPlan());
+ statement.getConnection().getQueryServices().getProps()),
null, false, ImmutableStorageScheme.ONE_CELL_PER_COLUMN,
QualifierEncodingScheme.NON_ENCODED_QUALIFIERS,
PTable.EncodedCQCounter.NULL_COUNTER, true);
+ private static final KeyValue USE_STATS_FOR_QUERY_PLAN_KV =
createFirstOnRow(ByteUtil.EMPTY_BYTE_ARRAY, TABLE_FAMILY_BYTES,
USE_STATS_FOR_QUERY_PLAN_BYTES);
+ private static final int USE_STATS_FOR_QUERY_PLAN_INDEX =
TABLE_KV_COLUMNS.indexOf(USE_STATS_FOR_QUERY_PLAN_KV);
+ boolean useStatsForQueryPlan = useStatsForQueryPlanKv == null ? true :
Boolean.TRUE.equals(PBoolean.INSTANCE.toObject(useStatsForQueryPlanKv.getValueArray(),
useStatsForQueryPlanKv.getValueOffset(),
useStatsForQueryPlanKv.getValueLength()));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AggregateIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryWithLimitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SysTableNamespaceMappedStatsCollectorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.RoundRobinResultIteratorWithStatsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryWithOffsetIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryTimeoutIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsCollectorIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/918//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/918//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/918//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/918//console
This message is automatically generated.
> Provide a way to collect stats and not use it for query parallelization
> -----------------------------------------------------------------------
>
> Key: PHOENIX-3834
> URL: https://issues.apache.org/jira/browse/PHOENIX-3834
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-3834.patch, PHOENIX-3834_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
