[
https://issues.apache.org/jira/browse/PHOENIX-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033553#comment-16033553
]
Karan Mehta commented on PHOENIX-3896:
--------------------------------------
There are still more corner cases and race conditions which I debugged even
after this patch. The only possible solution is to separate
{{TraceSpanReceiver}} for each test and have their individual {{TraceWriter}},
along with the global one present (which is constructed only once in a
{{Tracing.java}} in a static method, this one is meant for production). Each
new {{TraceSpanReceiver}} can be registered using the method
{{Trace#addReceiver()}}. After the test is completed, it is removed using
{{Trace#removeReceiver()}}, thus it stop receiving spans from other tests.
Instead of explicitly calling {{TraceSpanReceiver#receiveSpan()}}, we can use
the Htrace API {{Tracer#deliver(span)}} for sending out the traces to all the
receivers. This should hopefully remove any race conditions.
I will be putting up a new patch soon.
> Fix test failures related to tracing changes
> --------------------------------------------
>
> Key: PHOENIX-3896
> URL: https://issues.apache.org/jira/browse/PHOENIX-3896
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Karan Mehta
> Attachments: PHOENIX-3896.001.patch
>
>
> Looks like our unit tests are breaking after these commits:
> - PHOENIX-3248 Enable HBase server-side scan metrics to be returned to client
> and surfaced through metrics
> - PHOENIX-3752 Remove hadoop metrics integration from the tracing framework
> For example, see https://builds.apache.org/job/Phoenix-master/1628/ and
> https://builds.apache.org/job/Phoenix-4.x-HBase-1.1/405/.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
