[ 
https://issues.apache.org/jira/browse/PHOENIX-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035549#comment-16035549
 ] 

Hadoop QA commented on PHOENIX-3908:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12871059/PHOENIX-3908.patch
  against master branch at commit 9b8235eb8febbdee648d800eb578617023071dcc.
  ATTACHMENT ID: 12871059

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
45 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            String createQry = "create table "+tableName+" (k VARCHAR 
PRIMARY KEY, v1 VARCHAR, v2 VARCHAR)"
+                "CREATE VIEW "+viewName+" (v43 VARCHAR) AS SELECT * FROM 
"+tableName+" WHERE v1 = 'value1'";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/990//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/990//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/990//console

This message is automatically generated.

> Ensure MetaDataEntityNotFound handled for CREATE VIEW
> -----------------------------------------------------
>
>                 Key: PHOENIX-3908
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3908
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Maddineni Sukumar
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3908.patch
>
>
> We may already handle this (if so please close), but it's possible that a 
> CREATE VIEW statement could reference a table that was created in a different 
> connection. We should add a test for this in 
> UpdateCacheAcrossDifferentClientsIT and a similar retry loop as was done in 
> PhoenixStatement within CreateTableCompiler here:
> {code}
>         return new BaseMutationPlan(context, operation) {
>             @Override
>             public MutationState execute() throws SQLException {
>                 try {
>                     return client.createTable(finalCreate, splits, parent, 
> viewStatement, viewType, viewColumnConstants, isViewColumnReferenced);
>                 } finally {
>                     if (client.getConnection() != connection) {
>                         client.getConnection().close();
>                     }
>                 }
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to