[
https://issues.apache.org/jira/browse/PHOENIX-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037801#comment-16037801
]
Hadoop QA commented on PHOENIX-3907:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12871300/PHOENIX-3907.patch
against master branch at commit bacaba18bd17d54ff6b24fb5e59c6ab0a6ce62f1.
ATTACHMENT ID: 12871300
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 5 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SortMergeJoinIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1000//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1000//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1000//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1000//console
This message is automatically generated.
> Use LATEST_TIMESTAMP when UPDATE_CACHE_FREQUENCY is not zero
> ------------------------------------------------------------
>
> Key: PHOENIX-3907
> URL: https://issues.apache.org/jira/browse/PHOENIX-3907
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-3907.patch
>
>
> For non transactional tables, currently with UPDATE_CACHE_FREQUENCY, we'll
> use LATEST_TIMESTAMP *most* of the time, until the cached entity expires, in
> which case we'll use the server timestamp. This seems a bit strange and
> inconsistent. Instead (for non transactional tables), we should always use
> LATEST_TIMESTAMP if UPDATE_CACHE_FREQUENCY is non zero, with the exception of
> the corner case for UPSERT SELECT and DELETE where the same table is being
> read and written to (see changes to FromCompiler for PHOENIX-3823).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
