[
https://issues.apache.org/jira/browse/PHOENIX-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043725#comment-16043725
]
Hadoop QA commented on PHOENIX-3918:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12872168/PHOENIX-3918-v2.patch
against master branch at commit b9bb918610c04e21b27df8d3fe1c42df508a96f0.
ATTACHMENT ID: 12872168
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
50 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 5 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("CREATE TABLE " + tableName + "(k1
decimal, k2 decimal, constraint pk primary key (k1))");
+ ResultSet rs = conn.createStatement().executeQuery("SELECT
coalesce(null, null) FROM " + tableName);
+ String ddl = "CREATE TABLE " + tableName + " ( pk VARCHAR(10) NOT
NULL, val INTEGER CONSTRAINT PK PRIMARY KEY (pk))";
+ PreparedStatement ps = conn.prepareStatement("UPSERT INTO " +
tableName + " (pk,val) VALUES (?,?)");
+ ResultSet rs = conn.createStatement().executeQuery("SELECT ENCODE(val,
'BASE62') FROM " + tableName);
+ .executeQuery("SELECT OCTET_LENGTH(vb1),
OCTET_LENGTH(b), OCTET_LENGTH(vb2) FROM " + TABLE_NAME);
+ conn.createStatement().execute("CREATE TABLE " + tableName + " (k
CHAR(3) PRIMARY KEY, v1 VARCHAR, v2 INTEGER)");
+ if (ptr.getLength()!=0 &&
!secondChild.getDataType().isCoercibleTo(firstChild.getDataType(),
secondChild.getDataType().toObject(ptr))) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CreateTableIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CountDistinctCompressionIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1054//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1054//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1054//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1054//console
This message is automatically generated.
> Ensure all function implementations handle null args correctly
> --------------------------------------------------------------
>
> Key: PHOENIX-3918
> URL: https://issues.apache.org/jira/browse/PHOENIX-3918
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3918.patch, PHOENIX-3918-v2.patch
>
>
> {code}
> testBothParametersNull(org.apache.phoenix.end2end.TimezoneOffsetFunctionIT)
> Time elapsed: 2.272 sec <<< ERROR!
> java.sql.SQLException: ERROR 201 (22000): Illegal data. Unknown timezone
> at
> org.apache.phoenix.end2end.TimezoneOffsetFunctionIT.testBothParametersNull(TimezoneOffsetFunctionIT.java:130)
> timezoneParameterNull(org.apache.phoenix.end2end.TimezoneOffsetFunctionIT)
> Time elapsed: 2.273 sec <<< ERROR!
> java.sql.SQLException: ERROR 201 (22000): Illegal data. Unknown timezone
> at
> org.apache.phoenix.end2end.TimezoneOffsetFunctionIT.timezoneParameterNull(TimezoneOffsetFunctionIT.java:151)
> dateParameterNull(org.apache.phoenix.end2end.TimezoneOffsetFunctionIT) Time
> elapsed: 2.254 sec <<< ERROR!
> java.sql.SQLException: ERROR 201 (22000): Illegal data. Expected length of at
> least 8 bytes, but had 0
> at
> org.apache.phoenix.end2end.TimezoneOffsetFunctionIT.dateParameterNull(TimezoneOffsetFunctionIT.java:172)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
