[
https://issues.apache.org/jira/browse/PHOENIX-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086557#comment-16086557
]
Hadoop QA commented on PHOENIX-3997:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12877156/PHOENIX-3997-v3.patch
against master branch at commit 8a34de7a4c74584f5fb3a7ab9aaa64fd6269717b.
ATTACHMENT ID: 12877156
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
51 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private void commitBatch(Region region, List<Mutation> mutations, long
blockingMemstoreSize) throws IOException {
+ private void setIndexAndTransactionProperties(List<Mutation> mutations,
byte[] indexUUID, byte[] indexMaintainersPtr, byte[] txState, boolean
useIndexProto) {
+ m.setAttribute(useIndexProto ? PhoenixIndexCodec.INDEX_PROTO_MD
: PhoenixIndexCodec.INDEX_MD, indexMaintainersPtr);
+ isPKChanging = ExpressionUtil.isPkPositionChanging(new
TableRef(projectedTable), selectExpressions);
+ commit(region, mutations, indexUUID,
blockingMemStoreSize, indexMaintainersPtr,
+ setIndexAndTransactionProperties(indexMutations,
indexUUID, indexMaintainersPtr, txState, useIndexProto);
+ private void commit(Region region, List<Mutation> mutations, byte[]
indexUUID, long blockingMemStoreSize,
+ setIndexAndTransactionProperties(mutations, indexUUID,
indexMaintainersPtr, txState, useIndexProto);
+ separateLocalAndRemoteMutations(targetHTable, region, mutations,
localRegionMutations, remoteRegionMutations,
+ private void separateLocalAndRemoteMutations(HTable targetHTable, Region
region, List<Mutation> mutations,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1212//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1212//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1212//console
This message is automatically generated.
> UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the
> memstore size and wait for flush.
> ----------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3997
> URL: https://issues.apache.org/jira/browse/PHOENIX-3997
> Project: Phoenix
> Issue Type: Bug
> Reporter: Thomas D'Silva
> Assignee: Geoffrey Jacoby
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3997.patch, PHOENIX-3997-v2.patch,
> PHOENIX-3997-v3.patch
>
>
> [~ankit.singhal]
> In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to
> check the memstore size and wait for the flush. We are using a htable to
> write the mutations.
> {code}
> // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds
> for the
> // flush happen which decrease the memstore size and then writes
> allowed on the region.
> for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize
> && i < 30; i++) {
> try {
> checkForRegionClosing();
> Thread.sleep(100);
> } catch (InterruptedException e) {
> Thread.currentThread().interrupt();
> throw new IOException(e);
> }
> }
> logger.debug("Committing batch of " + mutations.size() + " mutations
> for " + table);
> try {
> table.batch(mutations);
> } catch (InterruptedException e) {
> throw new RuntimeException(e);
> }
> {code}
> FYI [~jamestaylor] [~apurtell]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
