[
https://issues.apache.org/jira/browse/PHOENIX-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088459#comment-16088459
]
Hadoop QA commented on PHOENIX-3948:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12877425/PHOENIX-3948.master.v3.patch
against master branch at commit 3477977f3589e5458013715652953a6aa1697814.
ATTACHMENT ID: 12877425
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
52 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // lower the number of rpc retries. We inherit config from
HConnectionManager#setServerSideHConnectionRetries,
+ // which by default uses a multiplier of 10. That is too many retries
for our synchronous index writes
+ public static final String INDEX_WRITER_RPC_RETRIES_NUMBER =
"phoenix.index.writes.rpc.retries.number";
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1218//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1218//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1218//console
This message is automatically generated.
> Enable shorter time outs for server-side index writes
> -----------------------------------------------------
>
> Key: PHOENIX-3948
> URL: https://issues.apache.org/jira/browse/PHOENIX-3948
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Vincent Poon
> Labels: globalMutableSecondaryIndex
> Attachments: PHOENIX-3948.master.v1.patch,
> PHOENIX-3948.master.v2.patch, PHOENIX-3948.master.v3.patch
>
>
> The default timeouts are far too high for a RS->RS global index update as
> we're holding on to a handler thread when the retries occur. We should be
> able to set them to be inline with the client-side timeouts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
