[ https://issues.apache.org/jira/browse/PHOENIX-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093555#comment-16093555 ]
Josh Elser commented on PHOENIX-3807: ------------------------------------- bq. Apologies Josh Elser, forgot about that and forgot to mention it. It looks like your patch is ready for when a new 1.4 branch is available though. No worries! It just made me turn my head in confusion when I got compilation errors :) Let me propose this: * I'll back-port out my "stock" hadoop metrics2 patch which did nearly the same thing you have here as a stopgap * I'll update the nomenclature in my patch to match what you have here * We'll plan to revert the hadoop metrics2 patch for every Phoenix version that has the hbase metrics API available Sound good? > Add server level metrics for secondary indexes > ---------------------------------------------- > > Key: PHOENIX-3807 > URL: https://issues.apache.org/jira/browse/PHOENIX-3807 > Project: Phoenix > Issue Type: Improvement > Reporter: Andrew Purtell > Assignee: Vincent Poon > Fix For: 4.12.0 > > Attachments: PHOENIX-3807.v1.master.patch, PHOENIX-3807.v2.patch, > PHOENIX-3807.v3.patch, Screen Shot 2017-05-31 at 4.00.16 PM.png > > > Add server level metrics for secondary indexes > - Histogram metrics for time to complete all secondary index updates per > primary table update per index type. Will help us trend perf over time and > catch impending issues. > - Histogram metrics for number of updates dispatched to secondary index > stores to service one primary table update per index type. Will help us catch > inefficient behavior or problematic schema design. > - Count of deployed secondary indexes by type. Will help understand and trend > index usage, or catch deploy of an unwanted index type. -- This message was sent by Atlassian JIRA (v6.4.14#64029)