[
https://issues.apache.org/jira/browse/PHOENIX-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093928#comment-16093928
]
Hadoop QA commented on PHOENIX-4042:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12878044/PHOENIX-4042.001.patch
against master branch at commit bff368d493c41cc9b71dfd70b3261ff54de6938c.
ATTACHMENT ID: 12878044
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
51 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static final String INDEXER_INDEX_WRITE_SLOW_THRESHOLD_KEY =
"phoenix.indexer.slow.post.batch.mutate.threshold";
+ private static final String INDEXER_INDEX_PREPARE_SLOW_THRESHOLD_KEY =
"phoenix.indexer.slow.pre.batch.mutate.threshold";
+ private static final String INDEXER_PRE_WAL_RESTORE_SLOW_THRESHOLD_KEY =
"phoenix.indexer.slow.pre.wal.restore.threshold";
+ private static final String INDEXER_POST_OPEN_SLOW_THRESHOLD_KEY =
"phoenix.indexer.slow.open.threshold";
+ private static final String INDEXER_PRE_INCREMENT_SLOW_THRESHOLD_KEY =
"phoenix.indexer.slow.pre.increment";
+ LOG.debug(getCallTooSlowMessage("preIncrementAfterRowLock",
duration, slowPreIncrementThreshold));
+ LOG.debug(getCallTooSlowMessage("preBatchMutate", duration,
slowIndexPrepareThreshold));
+ LOG.debug(getCallTooSlowMessage("indexPrepare", duration,
slowIndexPrepareThreshold));
+ //each batch operation, only the first one will have anything
useful, so we can just grab that
+
LOG.debug(getCallTooSlowMessage("postBatchMutateIndispensably", duration,
slowIndexWriteThreshold));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DefaultColumnValueIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DateTimeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DeleteIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexSaltedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientTimeArithmeticQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.TxWriteFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1230//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1230//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1230//console
This message is automatically generated.
> Add hadoop-metrics2 server level metrics for secondary indexes
> --------------------------------------------------------------
>
> Key: PHOENIX-4042
> URL: https://issues.apache.org/jira/browse/PHOENIX-4042
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4042.001.patch
>
>
> PHOENIX-3807 has a patch which uses the new hbase-metrics API for capturing
> Phoenix 2ndary indexing metrics inside of the RS.
> However, the hbase-metrics API doesn't show up until HBase-1.4. Let's put
> together an implementation that works with hadoop metrics2 to hold us over
> until that point.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
