[
https://issues.apache.org/jira/browse/PHOENIX-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095306#comment-16095306
]
James Taylor commented on PHOENIX-4022:
---------------------------------------
Thanks for the update, [~tdsilva] and for pointing out that the setQueryTimeout
is disallowed. I don't think that change belongs here. IMHO, it's not good
practice to disable support for a JDBC API and I don't think we should combine
that with this logging support. If users want to disable that in their own
distributions, that'd be fine, or perhaps we could support that through a
separate, orthogonal feature by introducing a new config parameter? I'd be
curious to know why users would want to disable it, though. If it's some kind
of service protection issue, there may be other approaches.
> Add PhoenixMetricsLog interface that can be used to log metrics for queries
> and mutations.
> -------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4022
> URL: https://issues.apache.org/jira/browse/PHOENIX-4022
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4022.patch, PHOENIX-4022-v2.patch
>
>
> Create a wrapper for PhoenixConnection, PhoenixStatement,
> PhoenixPreparedStatement and PhoenixResultSet that automatically calls the
> PhoenixMetricsLog logging methods so users don't have to instrument this
> themselves.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
