[
https://issues.apache.org/jira/browse/PHOENIX-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131005#comment-16131005
]
Hadoop QA commented on PHOENIX-2048:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12882386/PHOENIX-2048.patch
against master branch at commit b13413614fef3cdb87233fd1543081e7198d685f.
ATTACHMENT ID: 12882386
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
56 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String query = "select to_char(col_decimal, '" + pattern + "')
from " + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+ String query = "select to_char(col_date, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+ String query = "select to_char(col_time, '" + pattern + "') from " +
TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+ String query = "select to_char(col_timestamp, '" + pattern + "') from
" + TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+ String query = "select to_char(col_integer, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
+ String query = "select to_char(col_decimal, '" + pattern + "') from "
+ TO_CHAR_TABLE_NAME + " WHERE pk = " + pk;
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1270//console
This message is automatically generated.
> change to_char() function to use HALF_UP rounding mode
> ------------------------------------------------------
>
> Key: PHOENIX-2048
> URL: https://issues.apache.org/jira/browse/PHOENIX-2048
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: verify
> Reporter: Jonathan Leech
> Assignee: Csaba Skrabak
> Priority: Minor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-2048.patch
>
>
> to_char() function uses the default rounding mode in java DecimalFormat,
> which is a strange one called HALF_EVEN, which rounds a '5' in the last
> position either up or down depending on the preceding digit.
> Change it to HALF_UP so it rounds the same way as the round() function does,
> or provide a way to override the behavior; e.g. globally or as a client
> config, or an argument to the to_char() function.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
